External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-10-08 07:15:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemu: Shared or readonly disks are always safe wrt migration

Browse Source 
No matter what cache mode is used, readonly disks are always safe wrt
migration. Shared disks are required to be readonly or to disable
host-side cache, which makes them safe as well.
This commit is contained in:
Jiri Denemark 2012-03-05 12:10:21 +01:00
parent 6c3642e9bc
commit 07dd6fb610
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/qemu/qemu_migration.c
View File

@ -828,10 +828,12 @@ qemuMigrationIsSafe(virDomainDefPtr def)
for (i = 0 ; i < def->ndisks ; i++) {
virDomainDiskDefPtr disk = def->disks[i];
/* shared && !readonly implies cache=none */
/* Our code elsewhere guarantees shared disks are either readonly (in
* which case cache mode doesn't matter) or used with cache=none */
if (disk->src &&
disk->cachemode != VIR_DOMAIN_DISK_CACHE_DISABLE &&
(disk->cachemode || !disk->shared || disk->readonly)) {
!disk->shared &&
!disk->readonly &&
disk->cachemode != VIR_DOMAIN_DISK_CACHE_DISABLE) {
int cfs;
if ((cfs = virStorageFileIsClusterFS(disk->src)) == 1)
continue;