External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-03 03:25:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "capabilities: report full external snapshot support"

Browse Source 
Reverting external snapshot for running VM doesn't work correctly so we
should not report this capability until it is fixed.

This reverts commit de71573bfe.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
This commit is contained in:
Pavel Hrdina 2023-09-01 10:32:17 +02:00 committed by Jiri Denemark
parent aa5895cbc7
commit 0873d63b09
14 changed files with 0 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
docs/formatcaps.rst
View File

@ -134,12 +134,6 @@ The ``<guest/>`` element will typically wrap up the following elements:
creating external disk snapshots is supported. If absent, creating external
snapshots may still be supported, but it requires attempting the API and
checking for an error to find out for sure. :since:`Since 1.2.3`
``externalSnapshot``
If this element is present, the hypervisor supports deleting and
reverting external snapshots including memory state. Support for creation
of external snapshots is reported via the ``disksnapshot`` feature flag.
Management applications can now switch from internal snapshots to external
snapshots. :since:`Since 9.7.0`
Examples
~~~~~~~~
@ -324,7 +318,6 @@ capabilities enabled in the chip and BIOS you will see:
<cpuselection/>
<deviceboot/>
<disksnapshot default='on' toggle='no'/>
<externalSnapshot/>
</features>
</guest>

1
src/conf/capabilities.c
View File

@ -508,7 +508,6 @@ static const struct virCapsGuestFeatureInfo virCapsGuestFeatureInfos[VIR_CAPS_GU
[VIR_CAPS_GUEST_FEATURE_TYPE_DEVICEBOOT] = { "deviceboot", false },
[VIR_CAPS_GUEST_FEATURE_TYPE_DISKSNAPSHOT] = { "disksnapshot", true },
[VIR_CAPS_GUEST_FEATURE_TYPE_HAP] = { "hap", true },
[VIR_CAPS_GUEST_FEATURE_TYPE_EXTERNAL_SNAPSHOT] = { "externalSnapshot", false },
};

1
src/conf/capabilities.h
View File

@ -40,7 +40,6 @@ typedef enum {
VIR_CAPS_GUEST_FEATURE_TYPE_DEVICEBOOT,
VIR_CAPS_GUEST_FEATURE_TYPE_DISKSNAPSHOT,
VIR_CAPS_GUEST_FEATURE_TYPE_HAP,
VIR_CAPS_GUEST_FEATURE_TYPE_EXTERNAL_SNAPSHOT,
VIR_CAPS_GUEST_FEATURE_TYPE_LAST
} virCapsGuestFeatureType;

5
src/conf/schemas/capability.rng
View File

@ -493,11 +493,6 @@
<empty/>
</element>
</optional>
<optional>
<element name="externalSnapshot">
<empty/>
</element>
</optional>
</interleave>
</element>
</define>

1
src/qemu/qemu_capabilities.c
View File

@ -1121,7 +1121,6 @@ virQEMUCapsInitGuestFromBinary(virCaps *caps,
virCapabilitiesAddGuestFeature(guest, VIR_CAPS_GUEST_FEATURE_TYPE_DEVICEBOOT);
virCapabilitiesAddGuestFeatureWithToggle(guest, VIR_CAPS_GUEST_FEATURE_TYPE_DISKSNAPSHOT,
true, false);
virCapabilitiesAddGuestFeature(guest, VIR_CAPS_GUEST_FEATURE_TYPE_EXTERNAL_SNAPSHOT);
if (virQEMUCapsGet(qemuCaps, QEMU_CAPS_TCG)) {
virCapabilitiesAddGuestDomain(guest, VIR_DOMAIN_VIRT_QEMU,

1
tests/qemucaps2xmloutdata/caps.aarch64+hvf.xml
View File

@ -21,7 +21,6 @@
<cpuselection/>
<deviceboot/>
<disksnapshot default='on' toggle='no'/>
<externalSnapshot/>
</features>
</guest>

1
tests/qemucaps2xmloutdata/caps.aarch64.xml
View File

@ -21,7 +21,6 @@
<cpuselection/>
<deviceboot/>
<disksnapshot default='on' toggle='no'/>
<externalSnapshot/>
</features>
</guest>

1
tests/qemucaps2xmloutdata/caps.ppc.xml
View File

@ -19,7 +19,6 @@
<cpuselection/>
<deviceboot/>
<disksnapshot default='on' toggle='no'/>
<externalSnapshot/>
</features>
</guest>

1
tests/qemucaps2xmloutdata/caps.ppc64.xml
View File

@ -20,7 +20,6 @@
<cpuselection/>
<deviceboot/>
<disksnapshot default='on' toggle='no'/>
<externalSnapshot/>
</features>
</guest>

1
tests/qemucaps2xmloutdata/caps.riscv64.xml
View File

@ -19,7 +19,6 @@
<cpuselection/>
<deviceboot/>
<disksnapshot default='on' toggle='no'/>
<externalSnapshot/>
</features>
</guest>

1
tests/qemucaps2xmloutdata/caps.s390x.xml
View File

@ -20,7 +20,6 @@
<cpuselection/>
<deviceboot/>
<disksnapshot default='on' toggle='no'/>
<externalSnapshot/>
</features>
</guest>

1
tests/qemucaps2xmloutdata/caps.sparc.xml
View File

@ -19,7 +19,6 @@
<cpuselection/>
<deviceboot/>
<disksnapshot default='on' toggle='no'/>
<externalSnapshot/>
</features>
</guest>

1
tests/qemucaps2xmloutdata/caps.x86_64+hvf.xml
View File

@ -22,7 +22,6 @@
<cpuselection/>
<deviceboot/>
<disksnapshot default='on' toggle='no'/>
<externalSnapshot/>
</features>
</guest>

1
tests/qemucaps2xmloutdata/caps.x86_64.xml
View File

@ -22,7 +22,6 @@
<cpuselection/>
<deviceboot/>
<disksnapshot default='on' toggle='no'/>
<externalSnapshot/>
</features>
</guest>