mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2025-01-21 20:15:17 +00:00
tools: fix check_guests_shutdown loop
The recent fix to libvirt-guests.sh.in works for what it intended to fix (variable scope) but failed to adapt the loop in check_guests_shutdown correctly. Due to that it currently might detect all guests as "Failed to determine state of guest" by bad var content or just assumes they are shut down by picking up an empty variable. This commit fixes loop to use the passed value and the call in the loop to actually use the variable assigned in the iterated. Fixes: 7e476356 "tools: fix variable scope in in check_guests_shutdown" Fixes: https://bugs.launchpad.net/ubuntu/+source/libvirt/+bug/1764668 Reviewed-by: Dariusz Gadomski <dariusz.gadomski@canonical.com> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com> Signed-off-by: Michal Privoznik <mprivozn@redhat.com> Reviewed-by: Andrea Bolognani <abologna@redhat.com>
This commit is contained in:
parent
6009d5124f
commit
08bb5eeba7
@ -336,8 +336,8 @@ check_guests_shutdown()
|
||||
guests_to_check=$2
|
||||
|
||||
guests_shutting_down=
|
||||
for guest in $guests; do
|
||||
if ! guest_is_on "$uri" "$guests_to_check" >/dev/null 2>&1; then
|
||||
for guest in $guests_to_check; do
|
||||
if ! guest_is_on "$uri" "$guest" >/dev/null 2>&1; then
|
||||
eval_gettext "Failed to determine state of guest: \$guest. Not tracking it anymore."
|
||||
echo
|
||||
continue
|
||||
|
Loading…
x
Reference in New Issue
Block a user