External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-23 22:25:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemu driver: fix positioning to end of log file

Browse Source 
While doing some testing with Qemu and creating huge logfiles I encountered the case where the VM could not start anymore due to the lseek() to the end of the Qemu VM's log file failing. The patch below fixes the problem by replacing the previously used 'int' with 'off_t'.

To reproduce this error, you could do the following:

dd if=/dev/zero of=/var/log/libvirt/qemu/<name of VM>.log bs=1024 count=$((1024*2048))

and you should get an error like this:

error: Failed to start domain <name of VM>
error: Unable to seek to -2147482651 in /var/log/libvirt/qemu/<name of VM>.log: Success
This commit is contained in:
Stefan Berger 2011-01-04 12:46:10 -05:00
parent 45829e678e
commit 0922ff2fea
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/qemu/qemu_driver.c
View File

@ -2624,7 +2624,7 @@ static int qemudStartVMDaemon(virConnectPtr conn,
enum virVMOperationType vmop) { enum virVMOperationType vmop) {
int ret; int ret;
unsigned long long qemuCmdFlags; unsigned long long qemuCmdFlags;
int pos = -1; off_t pos = -1;
char ebuf[1024]; char ebuf[1024];
char *pidfile = NULL; char *pidfile = NULL;
int logfile = -1; int logfile = -1;