mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-08-27 19:11:16 +00:00
hacking: add a section on preprocessor conventions
* doc/hacking.html.in (preprocessor): New section to document recently-discussed style issues. Signed-off-by: Eric Blake <eblake@redhat.com>
This commit is contained in:
parent
0be3783316
commit
095375925e
14
HACKING
14
HACKING
@ -102,6 +102,20 @@ Usually they're in macro definitions or strings, and should be converted
|
|||||||
anyhow.
|
anyhow.
|
||||||
|
|
||||||
|
|
||||||
|
Preprocessor
|
||||||
|
============
|
||||||
|
For variadic macros, stick with C99 syntax:
|
||||||
|
|
||||||
|
#define vshPrint(_ctl, ...) fprintf(stdout, __VA_ARGS__)
|
||||||
|
|
||||||
|
Use parenthesis when checking if a macro is defined, and use
|
||||||
|
indentation to track nesting:
|
||||||
|
|
||||||
|
#if defined(HAVE_POSIX_FALLOCATE) && !defined(HAVE_FALLOCATE)
|
||||||
|
# define fallocate(a,ignored,b,c) posix_fallocate(a,b,c)
|
||||||
|
#endif
|
||||||
|
|
||||||
|
|
||||||
C types
|
C types
|
||||||
=======
|
=======
|
||||||
Use the right type.
|
Use the right type.
|
||||||
|
@ -124,6 +124,25 @@
|
|||||||
</p>
|
</p>
|
||||||
|
|
||||||
|
|
||||||
|
<h2><a href="types">Preprocessor</a></h2>
|
||||||
|
|
||||||
|
<p>
|
||||||
|
For variadic macros, stick with C99 syntax:
|
||||||
|
<pre>
|
||||||
|
#define vshPrint(_ctl, ...) fprintf(stdout, __VA_ARGS__)
|
||||||
|
</pre>
|
||||||
|
</p>
|
||||||
|
|
||||||
|
<p>Use parenthesis when checking if a macro is defined, and use
|
||||||
|
indentation to track nesting:
|
||||||
|
|
||||||
|
<pre>
|
||||||
|
#if defined(HAVE_POSIX_FALLOCATE) && !defined(HAVE_FALLOCATE)
|
||||||
|
# define fallocate(a,ignored,b,c) posix_fallocate(a,b,c)
|
||||||
|
#endif
|
||||||
|
</pre>
|
||||||
|
</p>
|
||||||
|
|
||||||
<h2><a href="types">C types</a></h2>
|
<h2><a href="types">C types</a></h2>
|
||||||
|
|
||||||
<p>
|
<p>
|
||||||
@ -405,7 +424,7 @@
|
|||||||
#include <limits.h>
|
#include <limits.h>
|
||||||
|
|
||||||
#if HAVE_NUMACTL Some system includes aren't supported
|
#if HAVE_NUMACTL Some system includes aren't supported
|
||||||
#include <numa.h> everywhere so need these #if defences.
|
# include <numa.h> everywhere so need these #if defences.
|
||||||
#endif
|
#endif
|
||||||
|
|
||||||
#include "internal.h" Include this first, after system includes.
|
#include "internal.h" Include this first, after system includes.
|
||||||
|
Loading…
Reference in New Issue
Block a user