mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-07-11 12:25:52 +00:00
cpu_s390: Don't check match attribute for host-model CPUs
The match attribute is only relevant for custom mode CPUs. Reporting failure when match == 'minimum' regardless on CPU mode can cause unexpected failures. We should only report the error for custom CPUs. In fact, calling virCPUs390Update on a custom mode CPU should always report an error as optional features are not supported on s390 either. Signed-off-by: Jiri Denemark <jdenemar@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
parent
af8e39921a
commit
0a24331c6e
@ -49,15 +49,15 @@ virCPUs390Update(virCPUDefPtr guest,
|
|||||||
int ret = -1;
|
int ret = -1;
|
||||||
size_t i;
|
size_t i;
|
||||||
|
|
||||||
if (guest->match == VIR_CPU_MATCH_MINIMUM) {
|
if (guest->mode == VIR_CPU_MODE_CUSTOM) {
|
||||||
virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
|
if (guest->match == VIR_CPU_MATCH_MINIMUM) {
|
||||||
_("match mode %s not supported"),
|
virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
|
||||||
virCPUMatchTypeToString(guest->match));
|
_("match mode %s not supported"),
|
||||||
goto cleanup;
|
virCPUMatchTypeToString(guest->match));
|
||||||
}
|
} else {
|
||||||
|
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
|
||||||
if (guest->mode != VIR_CPU_MODE_HOST_MODEL) {
|
_("optional CPU features are not supported"));
|
||||||
ret = 0;
|
}
|
||||||
goto cleanup;
|
goto cleanup;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user