External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-22 19:32:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

virrandom: Avoid undefined behaviour in virRandomBits

Browse Source 
If nbits is 64 (or greater) then shifting 1ULL left is undefined.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
Michal Privoznik 2018-08-02 09:29:38 +02:00
parent 1c701c47d5
commit 0a5a6f0d01
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/util/virrandom.c
View File

@ -68,7 +68,9 @@ uint64_t virRandomBits(int nbits)
return 0;
}
ret &= (1ULL << nbits) - 1;
if (nbits < 64)
ret &= (1ULL << nbits) - 1;
return ret;
}