From 0ba4066819db8be489f1f2c69865303a94e69361 Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Thu, 1 Jul 2021 16:03:58 +0200 Subject: [PATCH] virDomainSetBlockThreshold: Document that two events are fired when index isn't used Libvirt started emitting two threshold events, once with index and once withouth when the index isn't registered. Document this caveat. Signed-off-by: Peter Krempa Reviewed-by: Michal Privoznik --- src/libvirt-domain.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c index e48f3cdb02..35c0df0ebc 100644 --- a/src/libvirt-domain.c +++ b/src/libvirt-domain.c @@ -12637,6 +12637,10 @@ int virDomainGetGuestInfo(virDomainPtr domain, * live VM XML for 'backingStore' or 'source' elements of a disk. If index is * given the threshold is set for the corresponding image. * + * In case when @dev does not contain index the + * VIR_DOMAIN_EVENT_ID_BLOCK_THRESHOLD event may be emitted twice, once for the + * disk device target without index and once containing the index. + * * Note that the threshold event can be registered also for destinations of a * 'virDomainBlockCopy' destination by using the 'index' of the 'mirror' source. *