External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-10-03 12:55:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix memory leak issues in virshAllocpagesPagesizeCompleter.

Browse Source 
Signed-off-by: Roland Schulz <schullzroll@gmail.com>
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Roland Schulz 2018-05-23 14:40:41 +02:00 committed by Michal Privoznik
parent a8dc146a4d
commit 0babf84797
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tools/virsh-completer.c
View File

@ -576,6 +576,7 @@ virshAllocpagesPagesizeCompleter(vshControl *ctl,
virshControlPtr priv = ctl->privData;
unsigned int npages = 0;
xmlNodePtr *pages = NULL;
xmlDocPtr doc = NULL;
double size = 0;
size_t i = 0;
const char *suffix = NULL;
@ -595,7 +596,7 @@ virshAllocpagesPagesizeCompleter(vshControl *ctl,
if (!(cap_xml = virConnectGetCapabilities(priv->conn)))
goto error;
if (!(virXMLParseStringCtxt(cap_xml, _("capabilities"), &ctxt)))
if (!(doc = virXMLParseStringCtxt(cap_xml, _("capabilities"), &ctxt)))
goto error;
if (cellno && vshCommandOptStringQuiet(ctl, cmd, "cellno", &cellnum) > 0) {
@ -631,12 +632,11 @@ virshAllocpagesPagesizeCompleter(vshControl *ctl,
cleanup:
xmlXPathFreeContext(ctxt);
for (i = 0; i < npages; i++)
VIR_FREE(pages[i]);
VIR_FREE(pages);
VIR_FREE(cap_xml);
xmlFreeDoc(doc);
VIR_FREE(path);
VIR_FREE(pagesize);
VIR_FREE(cap_xml);
VIR_FREE(unit);
return ret;