External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-04 10:55:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemu: avoid NULL deref on error

Browse Source 
* src/qemu/qemu_command.c (qemuParseCommandLineDisk): Report error
before cleaning def.
This commit is contained in:
Eric Blake 2011-02-14 17:34:05 -07:00
parent bd6ea30384
commit 0cca53921d
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/qemu/qemu_command.c
View File

@ -4603,9 +4603,10 @@ qemuParseCommandLineDisk(virCapsPtr caps,
host = def->src + strlen("nbd:"); host = def->src + strlen("nbd:");
port = strchr(host, ':'); port = strchr(host, ':');
if (!port) { if (!port) {
def = NULL;
qemuReportError(VIR_ERR_INTERNAL_ERROR, qemuReportError(VIR_ERR_INTERNAL_ERROR,
_("cannot parse nbd filename '%s'"), def->src); _("cannot parse nbd filename '%s'"),
def->src);
def = NULL;
goto cleanup; goto cleanup;
} }
*port++ = '\0'; *port++ = '\0';