External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-22 19:32:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

conf: fix leak when parsing network port XML

Browse Source 
Use auto free to avoid leaking the "trustGuestRxFilters" strings

Reviewed-by: John Ferlan <jferlan@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
Daniel P. Berrangé 2019-06-18 18:29:26 +01:00
parent cdd362e0e7
commit 0ce813a878
1 changed files with 9 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/conf/virnetworkportdef.c
View File

@ -76,19 +76,19 @@ static virNetworkPortDefPtr
virNetworkPortDefParseXML(xmlXPathContextPtr ctxt)
{
virNetworkPortDefPtr def;
char *uuid = NULL;
VIR_AUTOFREE(char *) uuid = NULL;
xmlNodePtr virtPortNode;
xmlNodePtr vlanNode;
xmlNodePtr bandwidthNode;
xmlNodePtr addressNode;
char *trustGuestRxFilters = NULL;
char *mac = NULL;
char *macmgr = NULL;
char *mode = NULL;
char *plugtype = NULL;
char *managed = NULL;
char *driver = NULL;
char *class_id = NULL;
VIR_AUTOFREE(char *) trustGuestRxFilters = NULL;
VIR_AUTOFREE(char *) mac = NULL;
VIR_AUTOFREE(char *) macmgr = NULL;
VIR_AUTOFREE(char *) mode = NULL;
VIR_AUTOFREE(char *) plugtype = NULL;
VIR_AUTOFREE(char *) managed = NULL;
VIR_AUTOFREE(char *) driver = NULL;
VIR_AUTOFREE(char *) class_id = NULL;
if (VIR_ALLOC(def) < 0)
return NULL;
@ -255,14 +255,6 @@ virNetworkPortDefParseXML(xmlXPathContextPtr ctxt)
}
cleanup:
VIR_FREE(class_id);
VIR_FREE(uuid);
VIR_FREE(plugtype);
VIR_FREE(mac);
VIR_FREE(mode);
VIR_FREE(macmgr);
VIR_FREE(driver);
VIR_FREE(managed);
return def;
error: