External/libvirt
1
0
Fork 0
Code

networkRefreshDhcpDaemon: Get dnsmasq's PID once

Browse Source 
This is a relic of commit v3.7.0-rc1~132 when getter/setter APIs
for dnsmasq's PID were introduced. Previously, obj->dnsmasqPid
was accessed directly. But the aforementioned commit introduced
two calls to virNetworkObjGetDnsmasqPid() even though the result
of the first call is stored in a variable.

Remove the second call as it's unnecessary.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Michal Privoznik 2023-04-17 10:10:15 +02:00
parent 004d5141c5
commit 0d0604a51a
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/network/bridge_driver.c
View File

@ -1599,7 +1599,6 @@ networkRefreshDhcpDaemon(virNetworkDriverState *driver,
if (dnsmasqSave(dctx) < 0) if (dnsmasqSave(dctx) < 0)
return -1; return -1;
dnsmasqPid = virNetworkObjGetDnsmasqPid(obj);
return kill(dnsmasqPid, SIGHUP); return kill(dnsmasqPid, SIGHUP);
} }