External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-22 12:35:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

conf: Avoid false positive of uninitialized variable use

Browse Source 
GCC 4.8.0+ whines about variable "new" being uninitialized since
commit 73bfac0e7182a3abd. This is a false positive as the
xmlFreeNode(new) statement can be only reached if new was actually
allocated successfully.

  CC       conf/libvirt_conf_la-domain_conf.lo
  conf/domain_conf.c: In function 'virDomainDefSetMetadata':
  conf/domain_conf.c:18650:24: error: 'new' may be used uninitialized in this function [-Werror=maybe-uninitialized]
               xmlFreeNode(new);

Reported independently by John Ferlan and Michal Privoznik.
This commit is contained in:
Peter Krempa 2013-09-17 13:27:58 +02:00
parent 716c7bb1dd
commit 0d4f469c87
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/conf/domain_conf.c
View File

@ -18598,7 +18598,7 @@ virDomainDefSetMetadata(virDomainDefPtr def,
{ {
xmlDocPtr doc = NULL; xmlDocPtr doc = NULL;
xmlNodePtr old; xmlNodePtr old;
xmlNodePtr new; xmlNodePtr new = NULL;
char *tmp; char *tmp;
int ret = -1; int ret = -1;
@ -18647,11 +18647,8 @@ virDomainDefSetMetadata(virDomainDefPtr def,
xmlFreeNode(old); xmlFreeNode(old);
} }
/* just delete the metadata */ if (new &&
if (!metadata) !(xmlAddChild(def->metadata, new))) {
break;
if (!(xmlAddChild(def->metadata, new))) {
xmlFreeNode(new); xmlFreeNode(new);
virReportOOMError(); virReportOOMError();
goto cleanup; goto cleanup;