External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 13:45:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

virsh: Clear vsh last error during virshCommandOptVolBy

Browse Source 
https://bugzilla.redhat.com/show_bug.cgi?id=1529256

If one of the virStorageVolLookupBy{Key|Name|Path} succeeds and
we have a @vol, then clear the last libvirt error; otherwise, a
subsequent "other" failure may cause vshReportError to erroneously
report the wrong error as well as a reported 'vshError' error that
caused the failure.

Signed-off-by: John Ferlan <jferlan@redhat.com>
This commit is contained in:
John Ferlan 2018-04-16 11:40:23 -04:00
parent 3527f9dde6
commit 0d6e834103
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/virsh-volume.c
View File

@ -129,6 +129,8 @@ virshCommandOptVolBy(vshControl *ctl, const vshCmd *cmd,
else else
vshError(ctl, _("failed to get vol '%s', specifying --%s " vshError(ctl, _("failed to get vol '%s', specifying --%s "
"might help"), n, pooloptname); "might help"), n, pooloptname);
} else {
vshResetLibvirtError();
} }
/* If the pool was specified, then make sure that the returned /* If the pool was specified, then make sure that the returned