External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-07-08 02:45:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

virStream: Forbid negative seeks

Browse Source 
Currently, we don't assign any meaning to that. Our current view
on virStream is that it's merely a pipe. And pipes don't support
seeking.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Michal Privoznik 2017-05-18 08:27:27 +02:00
parent 445a340bd4
commit 0da4a635bc
3 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/internal.h
View File

@ -527,6 +527,13 @@
goto label; \
} \
} while (0)
# define virCheckPositiveArgReturn(argname, retval) \
do { \
if (argname <= 0) { \
virReportInvalidPositiveArg(argname); \
return retval; \
} \
} while (0)
# define virCheckNonZeroArgGoto(argname, label) \
do { \
if (argname == 0) { \

1
src/rpc/virnetclientstream.c
View File

@ -367,6 +367,7 @@ virNetClientStreamSetHole(virNetClientStreamPtr st,
unsigned int flags)
{
virCheckFlags(0, -1);
virCheckPositiveArgReturn(length, -1);
/* Shouldn't happen, But it's better to safe than sorry. */
if (st->holeLength) {

1
src/util/virfdstream.c
View File

@ -950,6 +950,7 @@ virFDStreamSendHole(virStreamPtr st,
int ret = -1;
virCheckFlags(0, -1);
virCheckPositiveArgReturn(length, -1);
virObjectLock(fdst);
if (fdst->length) {