External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-03 03:25:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

nss: Don't leak memory on parse error

Browse Source 
If yajl_parse() fails, we try to print an error message. For
that, yajl_get_error() is used. However, its documentation say
that caller is also responsible for freeing the memory it
allocates by using yajl_free_error().

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
Michal Privoznik 2019-08-09 10:37:05 +02:00
parent fd21db659d
commit 0dc84c347a
2 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tools/nss/libvirt_nss_leases.c
View File

@ -399,9 +399,10 @@ findLeases(const char *file,
if (yajl_parse(parser, (const unsigned char *)line, rv) !=
yajl_status_ok) {
ERROR("Parse failed %s",
yajl_get_error(parser, 1,
(const unsigned char*)line, rv));
unsigned char *err = yajl_get_error(parser, 1,
(const unsigned char*)line, rv);
ERROR("Parse failed %s", (const char *) err);
yajl_free_error(parser, err);
goto cleanup;
}
}

7
tools/nss/libvirt_nss_macs.c
View File

@ -252,9 +252,10 @@ findMACs(const char *file,
if (yajl_parse(parser, (const unsigned char *)line, rv) !=
yajl_status_ok) {
ERROR("Parse failed %s",
yajl_get_error(parser, 1,
(const unsigned char*)line, rv));
unsigned char *err = yajl_get_error(parser, 1,
(const unsigned char*)line, rv);
ERROR("Parse failed %s", (const char *) err);
yajl_free_error(parser, err);
goto cleanup;
}
}