From 0dd1fdae2e9f8a3e2ca8cd4c2aa5f475146d9623 Mon Sep 17 00:00:00 2001 From: Liu Yiding Date: Tue, 28 Jun 2022 11:53:35 +0800 Subject: [PATCH] conf: virDomainMemoryDefValidate: Improve error message An explicit limit would be more user friendly. Add the limit to error message. Before this commit: ``` error: requested size must be smaller than or equal to @size ``` Now: ``` error: requested size must be smaller than or equal to @size (8388608KiB) ``` Signed-off-by: Liu Yiding Reviewed-by: Michal Privoznik --- src/conf/domain_validate.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c index 33b6f47159..28b0481d4e 100644 --- a/src/conf/domain_validate.c +++ b/src/conf/domain_validate.c @@ -2194,8 +2194,9 @@ virDomainMemoryDefValidate(const virDomainMemoryDef *mem, case VIR_DOMAIN_MEMORY_MODEL_VIRTIO_MEM: if (mem->requestedsize > mem->size) { - virReportError(VIR_ERR_XML_DETAIL, "%s", - _("requested size must be smaller than or equal to @size")); + virReportError(VIR_ERR_XML_DETAIL, + _("requested size must be smaller than or equal to @size (%lluKiB)"), + mem->size); return -1; }