mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2025-01-11 23:37:42 +00:00
util: Change return type of virSCSIVHostDeviceSetUsedBy to void
This function return value is invariant since 18f3771, so change its type and remove all dependent checks. Found by Linux Verification Center (linuxtesting.org) with Svace. Reported-by: Pavel Nekrasov <p.nekrasov@fobos-nt.ru> Signed-off-by: Alexander Kuznetsov <kuznetsovam@altlinux.org> Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
This commit is contained in:
parent
20afcd4b14
commit
0e1a848733
src
@ -1667,8 +1667,7 @@ virHostdevPrepareSCSIVHostDevices(virHostdevManager *mgr,
|
||||
if (!(host = virSCSIVHostDeviceNew(hostsrc->wwpn)))
|
||||
return -1;
|
||||
|
||||
if (virSCSIVHostDeviceSetUsedBy(host, drv_name, dom_name) < 0)
|
||||
return -1;
|
||||
virSCSIVHostDeviceSetUsedBy(host, drv_name, dom_name);
|
||||
|
||||
if (virSCSIVHostDeviceListAdd(list, host) < 0)
|
||||
return -1;
|
||||
|
@ -193,7 +193,7 @@ virSCSIVHostDeviceListNew(void)
|
||||
}
|
||||
|
||||
|
||||
int
|
||||
void
|
||||
virSCSIVHostDeviceSetUsedBy(virSCSIVHostDevice *dev,
|
||||
const char *drvname,
|
||||
const char *domname)
|
||||
@ -202,8 +202,6 @@ virSCSIVHostDeviceSetUsedBy(virSCSIVHostDevice *dev,
|
||||
VIR_FREE(dev->used_by_domname);
|
||||
dev->used_by_drvname = g_strdup(drvname);
|
||||
dev->used_by_domname = g_strdup(domname);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
||||
|
@ -50,7 +50,7 @@ void virSCSIVHostDeviceListDel(virSCSIVHostDeviceList *list,
|
||||
virSCSIVHostDevice *dev);
|
||||
virSCSIVHostDeviceList *virSCSIVHostDeviceListNew(void);
|
||||
virSCSIVHostDevice *virSCSIVHostDeviceNew(const char *name);
|
||||
int virSCSIVHostDeviceSetUsedBy(virSCSIVHostDevice *dev,
|
||||
void virSCSIVHostDeviceSetUsedBy(virSCSIVHostDevice *dev,
|
||||
const char *drvname,
|
||||
const char *domname);
|
||||
void virSCSIVHostDeviceGetUsedBy(virSCSIVHostDevice *dev,
|
||||
|
Loading…
x
Reference in New Issue
Block a user