From 0f5ce3afd4141488d5feae8809eacf97f374daa3 Mon Sep 17 00:00:00 2001 From: Michal Privoznik Date: Thu, 16 May 2024 13:19:32 +0200 Subject: [PATCH] virprocess: Debug affinity map in virProcessSetAffinity() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The aim of virProcessSetAffinity() is to set affinity of given process to given CPUs. While we currently print the PID into logs, the CPU map is not printed. It may help when debugging weird scenarios. Signed-off-by: Michal Privoznik Reviewed-by: Ján Tomko --- src/util/virprocess.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/util/virprocess.c b/src/util/virprocess.c index 5cdf3e3eb9..f1e5e4decd 100644 --- a/src/util/virprocess.c +++ b/src/util/virprocess.c @@ -452,8 +452,9 @@ int virProcessSetAffinity(pid_t pid, { size_t i; cpuset_t mask; + g_autofree char *mapStr = virBitmapFormat(map); - VIR_DEBUG("Set process affinity on %lld", (long long)pid); + VIR_DEBUG("Set process affinity on %1$lld to %2$s", (long long)pid, mapStr); CPU_ZERO(&mask); for (i = 0; i < virBitmapSize(map); i++) { @@ -509,8 +510,9 @@ int virProcessSetAffinity(pid_t pid, virBitmap *map, bool quiet) size_t masklen; cpu_set_t *mask; int rv = -1; + g_autofree char *mapStr = virBitmapFormat(map); - VIR_DEBUG("Set process affinity on %lld", (long long)pid); + VIR_DEBUG("Set process affinity on %1$lld to %2$s", (long long)pid, mapStr); /* Not only may the statically allocated cpu_set_t be too small, * but there is no way to ask the kernel what size is large enough.