External/libvirt
1
0
Fork 0
Code

report OOM in two places in node_device_driver.c

Browse Source 
* src/node_device/node_device_driver.c: two places where not calling
  virReportOOMError after strdup failure
This commit is contained in:
Dave Allan 2009-11-19 15:44:00 +01:00 committed by Daniel Veillard
parent 278e947890
commit 0fe553744a
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/node_device/node_device_driver.c
View File

@ -175,6 +175,7 @@ nodeListDevices(virConnectPtr conn,
virNodeDeviceHasCap(driver->devs.objs[i], cap)) { virNodeDeviceHasCap(driver->devs.objs[i], cap)) {
if ((names[ndevs++] = strdup(driver->devs.objs[i]->def->name)) == NULL) { if ((names[ndevs++] = strdup(driver->devs.objs[i]->def->name)) == NULL) {
virNodeDeviceObjUnlock(driver->devs.objs[i]); virNodeDeviceObjUnlock(driver->devs.objs[i]);
virReportOOMError(conn);
goto failure; goto failure;
} }
} }
@ -379,8 +380,10 @@ nodeDeviceListCaps(virNodeDevicePtr dev, char **const names, int maxnames)
for (caps = obj->def->caps; caps && ncaps < maxnames; caps = caps->next) { for (caps = obj->def->caps; caps && ncaps < maxnames; caps = caps->next) {
names[ncaps] = strdup(virNodeDevCapTypeToString(caps->type)); names[ncaps] = strdup(virNodeDevCapTypeToString(caps->type));
if (names[ncaps++] == NULL) if (names[ncaps++] == NULL) {
virReportOOMError(dev->conn);
goto cleanup; goto cleanup;
}
} }
ret = ncaps; ret = ncaps;