mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2025-03-07 17:28:15 +00:00
qemu: Don't return memory device config on error in qemuBuildMemoryBackendStr
In the last section if the function determines that the config is invalid when QEMU doesn't support the memory device the JSON config object would be returned even if it doesn't make sense. Assign the object to be returned only on success.
This commit is contained in:
parent
c35b277671
commit
104011ea8b
@ -4750,9 +4750,6 @@ qemuBuildMemoryBackendStr(unsigned long long size,
|
||||
goto cleanup;
|
||||
}
|
||||
|
||||
*backendProps = props;
|
||||
props = NULL;
|
||||
|
||||
if (!hugepage) {
|
||||
bool nodeSpecified = virDomainNumatuneNodeSpecified(def->numa, guestNode);
|
||||
|
||||
@ -4767,11 +4764,15 @@ qemuBuildMemoryBackendStr(unsigned long long size,
|
||||
/* report back that using the new backend is not necessary to achieve
|
||||
* the desired configuration */
|
||||
if (!userNodeset && !nodeSpecified) {
|
||||
*backendProps = props;
|
||||
props = NULL;
|
||||
ret = 1;
|
||||
goto cleanup;
|
||||
}
|
||||
}
|
||||
|
||||
*backendProps = props;
|
||||
props = NULL;
|
||||
ret = 0;
|
||||
|
||||
cleanup:
|
||||
|
Loading…
x
Reference in New Issue
Block a user