Added additional check for failure of core dump on domain-0

This commit is contained in:
Daniel P. Berrange 2007-02-27 15:50:03 +00:00
parent 00602abe00
commit 10732a5071
2 changed files with 13 additions and 1 deletions

View File

@ -1,3 +1,8 @@
Tue Feb 27 10:49:35 EST 2007 Daniel P. Berrange <berrange@redhat.com>
* src/xend_internal.c: Check POST reply for 'Cannot' to detect
failure of core dump on Domain-0. Signed-off-by: Kazuki Mizushima
Tue Feb 27 10:35:35 EST 2007 Daniel P. Berrange <berrange@redhat.com> Tue Feb 27 10:35:35 EST 2007 Daniel P. Berrange <berrange@redhat.com>
* src/virsh.c: Fix SEGV when doing tab-completion of commands * src/virsh.c: Fix SEGV when doing tab-completion of commands

View File

@ -508,7 +508,14 @@ xend_post(virConnectPtr xend, const char *path, const char *ops,
if ((ret < 0) || (ret >= 300)) { if ((ret < 0) || (ret >= 300)) {
virXendError(xend, VIR_ERR_POST_FAILED, content); virXendError(xend, VIR_ERR_POST_FAILED, content);
} else if ((ret = 202) && (strstr(content, "failed") != NULL)) { } else if ((ret == 202) && (strstr(content, "failed") != NULL)) {
virXendError(xend, VIR_ERR_POST_FAILED, content);
ret = -1;
} else if ((ret == 202) && (strstr(content, "Cannot") != NULL)) {
/* This is to catch case of 'virsh dump Domain-0 foo'
* which returns a success code, but the word 'Cannot'
* in body to indicate error
*/
virXendError(xend, VIR_ERR_POST_FAILED, content); virXendError(xend, VIR_ERR_POST_FAILED, content);
ret = -1; ret = -1;
} }