External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-05 04:25:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

virbitmaptest: Split up test12

Browse Source 
'test12' was testing two distinct operations on two instances of a
bitmap. Split it up into 'test12a' and 'test12b' so that the 'bitmap'
variable is not reused.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Peter Krempa 2020-10-05 11:17:38 +02:00
parent 5eb6d5401d
commit 110b95d573
1 changed files with 17 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
tests/virbitmaptest.c
View File

@ -629,7 +629,7 @@ test11(const void *opaque)
/* test self-expanding bitmap APIs */ /* test self-expanding bitmap APIs */
static int static int
test12(const void *opaque G_GNUC_UNUSED) test12a(const void *opaque G_GNUC_UNUSED)
{ {
virBitmapPtr map = virBitmapNewEmpty(); virBitmapPtr map = virBitmapNewEmpty();
int ret = -1; int ret = -1;
@ -646,7 +646,20 @@ test12(const void *opaque G_GNUC_UNUSED)
TEST_MAP(151, "128"); TEST_MAP(151, "128");
ret = 0;
cleanup:
virBitmapFree(map); virBitmapFree(map);
return ret;
}
static int
test12b(const void *opaque G_GNUC_UNUSED)
{
virBitmapPtr map = virBitmapNewEmpty();
int ret = -1;
if (!(map = virBitmapParseUnlimited("34,1023"))) if (!(map = virBitmapParseUnlimited("34,1023")))
goto cleanup; goto cleanup;
@ -829,7 +842,9 @@ mymain(void)
TESTBINARYOP("0-3", "0,^0", "0,^0", test11); TESTBINARYOP("0-3", "0,^0", "0,^0", test11);
TESTBINARYOP("0,2", "1,3", "0,^0", test11); TESTBINARYOP("0,2", "1,3", "0,^0", test11);
if (virTestRun("test12", test12, NULL) < 0) if (virTestRun("test12a", test12a, NULL) < 0)
ret = -1;
if (virTestRun("test12b", test12b, NULL) < 0)
ret = -1; ret = -1;
if (virTestRun("test13", test13, NULL) < 0) if (virTestRun("test13", test13, NULL) < 0)
ret = -1; ret = -1;