External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

bridge: leases: Fix potential crash caused by use after free

Browse Source 
Don't free individual JSON array members as the array will be freed at
the end. This may potentially lead to a crash although it didn't crash
on my setup.
This commit is contained in:
Peter Krempa 2014-06-24 13:52:57 +02:00
parent 15b46520e5
commit 11863f7067
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/network/bridge_driver.c
View File

@ -3437,10 +3437,8 @@ networkGetDHCPLeasesHelper(virNetworkObjPtr obj,
goto error; goto error;
} }
if (mac && virMacAddrCompare(mac, mac_tmp)) { if (mac && virMacAddrCompare(mac, mac_tmp))
virJSONValueFree(lease_tmp);
continue; continue;
}
if (virJSONValueObjectGetNumberLong(lease_tmp, "expiry-time", &expirytime_tmp) < 0) { if (virJSONValueObjectGetNumberLong(lease_tmp, "expiry-time", &expirytime_tmp) < 0) {
/* A lease cannot be present without expiry-time */ /* A lease cannot be present without expiry-time */