External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-07-31 05:57:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemu_block: allow configuring autofinalize for block commit

Browse Source 
External snapshots will use this to synchronize qemu block jobs.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
This commit is contained in:
Pavel Hrdina 2023-01-02 14:46:51 +01:00
parent b308dc4b77
commit 11e30faf75
3 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/qemu/qemu_block.c
View File

@ -3207,11 +3207,17 @@ qemuBlockExportAddNBD(virDomainObj *vm,
* @top_parent: disk source that has @topSource as backing disk
* @bandwidth: bandwidth limit, flags determine the unit
* @asyncJob: qemu async job type
* @autofinalize: virTristateBool controlling qemu block job finalization
* @flags: bitwise-OR of virDomainBlockCommitFlags
*
* Starts a block commit job for @disk. If @asyncJob is different then
* VIR_ASYNC_JOB_NONE the job will be started as synchronous.
*
* The @autofinalize argument controls if the qemu block job will be automatically
* finalized. This is used when deleting external snapshots where we need to
* disable automatic finalization for some use-case. The default value passed
* to this argument should be VIR_TRISTATE_BOOL_YES.
*
* Returns -1 on error, 0 on success.
*/
int
@ -3222,6 +3228,7 @@ qemuBlockCommit(virDomainObj *vm,
virStorageSource *top_parent,
unsigned long bandwidth,
virDomainAsyncJob asyncJob,
virTristateBool autofinalize,
unsigned int flags)
{
qemuDomainObjPrivate *priv = vm->privateData;
@ -3365,7 +3372,7 @@ qemuBlockCommit(virDomainObj *vm,
topSource->nodeformat,
baseSource->nodeformat,
backingPath, bandwidth,
VIR_TRISTATE_BOOL_YES);
autofinalize);
qemuDomainObjExitMonitor(vm);

1
src/qemu/qemu_block.h
View File

@ -285,6 +285,7 @@ qemuBlockCommit(virDomainObj *vm,
virStorageSource *top_parent,
unsigned long bandwidth,
virDomainAsyncJob asyncJob,
virTristateBool autofinalize,
unsigned int flags);
int

3
src/qemu/qemu_driver.c
View File

@ -15026,7 +15026,8 @@ qemuDomainBlockCommit(virDomainPtr dom,
goto endjob;
ret = qemuBlockCommit(vm, disk, baseSource, topSource, top_parent,
bandwidth, VIR_ASYNC_JOB_NONE, flags);
bandwidth, VIR_ASYNC_JOB_NONE, VIR_TRISTATE_BOOL_YES,
flags);
endjob:
virDomainObjEndJob(vm);