External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-21 20:15:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

virsh: remove driver check from attach-disk command

Browse Source 
Virsh shouldn't check for driver support but rather let the backend handled this.
After removing the check, I can successfully attach file-based images to a qemu
VM with attach-disk.

% virsh attach-disk vm2 /images/test02.img vdc --driver qemu --type disk --subdriver raw
Disk attached successfully

This command generates the following XML:

<disk type='block' device='disk'>
      <driver name='qemu' type='raw'/>
      <source dev='/images/test02.img'/>
      <target dev='vdc' bus='virtio'/>
      <alias name='virtio-disk2'/>
      <address type='pci' domain='0x0000' bus='0x00' slot='0x09' function='0x0'/>
</disk>

Signed-off-by: Ryan Harper <ryanh@us.ibm.com>
This commit is contained in:
Ryan Harper 2010-08-24 11:09:00 -05:00 committed by Eric Blake
parent 9c4f62ae61
commit 12a41822e1
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tools/virsh.c
View File

@ -8146,13 +8146,8 @@ cmdAttachDisk(vshControl *ctl, const vshCmd *cmd)
mode = vshCommandOptString(cmd, "mode", NULL);
if (driver) {
if (STREQ(driver, "file") || STREQ(driver, "tap")) {
if (STREQ(driver, "file") || STREQ(driver, "tap"))
isFile = 1;
} else if (STRNEQ(driver, "phy")) {
vshError(ctl, _("No support for %s in command 'attach-disk'"),
driver);
goto cleanup;
}
}
if (mode) {