External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-27 06:55:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

util: Clear up some perf error messages

Browse Source 
Make it clearer that the perf event is based/for the host cpu and
use the virPerfEventTypeToString to convert the type to a string
This commit is contained in:
John Ferlan 2016-10-07 08:14:37 -04:00
parent 12629888fc
commit 12b2aebeba
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/util/virperf.c
View File

@ -175,7 +175,7 @@ virPerfEventEnable(virPerfPtr perf,
type == VIR_PERF_EVENT_MBMT || type == VIR_PERF_EVENT_MBMT ||
type == VIR_PERF_EVENT_MBML)) { type == VIR_PERF_EVENT_MBML)) {
virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED, virReportError(VIR_ERR_ARGUMENT_UNSUPPORTED,
_("unable to enable perf event for %s"), _("unable to enable host cpu perf event for %s"),
virPerfEventTypeToString(event->type)); virPerfEventTypeToString(event->type));
return -1; return -1;
} }
@ -205,14 +205,14 @@ virPerfEventEnable(virPerfPtr perf,
event->fd = syscall(__NR_perf_event_open, &attr, pid, -1, -1, 0); event->fd = syscall(__NR_perf_event_open, &attr, pid, -1, -1, 0);
if (event->fd < 0) { if (event->fd < 0) {
virReportSystemError(errno, virReportSystemError(errno,
_("Unable to open perf event for %s"), _("unable to open host cpu perf event for %s"),
virPerfEventTypeToString(event->type)); virPerfEventTypeToString(event->type));
goto error; goto error;
} }
if (ioctl(event->fd, PERF_EVENT_IOC_ENABLE) < 0) { if (ioctl(event->fd, PERF_EVENT_IOC_ENABLE) < 0) {
virReportSystemError(errno, virReportSystemError(errno,
_("Unable to enable perf event for %s"), _("unable to enable host cpu perf event for %s"),
virPerfEventTypeToString(event->type)); virPerfEventTypeToString(event->type));
goto error; goto error;
} }
@ -236,8 +236,8 @@ virPerfEventDisable(virPerfPtr perf,
if (ioctl(event->fd, PERF_EVENT_IOC_DISABLE) < 0) { if (ioctl(event->fd, PERF_EVENT_IOC_DISABLE) < 0) {
virReportSystemError(errno, virReportSystemError(errno,
_("Unable to disable perf event type=%d"), _("unable to disable host cpu perf event for %s"),
event->type); virPerfEventTypeToString(event->type));
return -1; return -1;
} }