External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-22 12:35:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

docs: hacking: emphasize some sections

Browse Source 
Namely:
* holding up the first-time patch submissions for moderation,
  which might cause first-time submitters to question the process
* not CC-ing individual developers

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
This commit is contained in:
Ján Tomko 2019-10-18 22:57:23 +02:00
parent 2825803477
commit 136d907ff6
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
docs/hacking.html.in
View File

@ -72,8 +72,8 @@
</pre> </pre>
<p>As a rule, patches should be sent to the mailing list only: all <p>As a rule, patches should be sent to the mailing list only: all
developers are subscribed to libvir-list and read it regularly, so developers are subscribed to libvir-list and read it regularly, so
please don't CC individual developers unless they've explicitly <strong>please don't CC individual developers</strong> unless
asked you to.</p> they've explicitly asked you to.</p>
<p>Avoid using mail clients for sending patches, as most of them <p>Avoid using mail clients for sending patches, as most of them
will mangle the messages in some way, making them unusable for our will mangle the messages in some way, making them unusable for our
purposes. Gmail and other Web-based mail clients are particularly purposes. Gmail and other Web-based mail clients are particularly
@ -81,9 +81,11 @@
<p>If everything went well, your patch should show up on the <p>If everything went well, your patch should show up on the
<a href="https://www.redhat.com/archives/libvir-list/">libvir-list <a href="https://www.redhat.com/archives/libvir-list/">libvir-list
archives</a> in a matter of minutes; if you still can't find it on archives</a> in a matter of minutes; if you still can't find it on
there after an hour or so, you should double-check your setup. Note there after an hour or so, you should double-check your setup.
that your very first post to the mailing list will be subject to <strong>Note that, if you are not already a subscriber, your very
moderation, and it's not uncommon for that to take around a day.</p> first post to the mailing list will be
subject to moderation</strong>, and it's not uncommon for that to
take around a day.</p>
<p>Please follow this as close as you can, especially the rebase and <p>Please follow this as close as you can, especially the rebase and
<code>git send-email</code> part, as it makes life easier for other <code>git send-email</code> part, as it makes life easier for other
developers to review your patch set.</p> developers to review your patch set.</p>