From 139a319794e6042979b9f4c198262fcce1ff18de Mon Sep 17 00:00:00 2001 From: Roman Bogorodskiy Date: Sun, 27 Mar 2016 10:59:22 -0400 Subject: [PATCH] Revert "logical: Only raw volumes are supported" This reverts commit 6682d6219d4595b51f06867e0c30e7efd745f682. The "if (vol->target.format != VIR_STORAGE_FILE_RAW)" check in the createVol backend. This check is bogus because virStorageVolDefParseXML() in conf/storage_conf.c sets target.format only if volOptions in virStoragePoolTypeInfo has formatFromString set, and that's not the case the logical backend. So the check always fails and breaks volume creation. --- src/storage/storage_backend_logical.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/storage/storage_backend_logical.c b/src/storage/storage_backend_logical.c index 39e8b80ed0..90a194ebc4 100644 --- a/src/storage/storage_backend_logical.c +++ b/src/storage/storage_backend_logical.c @@ -912,12 +912,6 @@ virStorageBackendLogicalCreateVol(virConnectPtr conn, struct stat sb; bool created = false; - if (vol->target.format != VIR_STORAGE_FILE_RAW) { - virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", - _("only RAW volumes are supported by this storage pool")); - return -1; - } - if (vol->target.encryption != NULL) { virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("storage pool does not support encrypted "