External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-01 17:35:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Allow brAddTap to create a tap device that is down

Browse Source 
An upcoming patch has a use for a tap device to be created that
doesn't need to be actually put into the "up" state, and keeping it
"down" keeps the output of ifconfig from being unnecessarily cluttered
(ifconfig won't show down interfaces unless you add "-a").

bridge.[ch]: add "up" as an arg to brAddTap()
uml_conf.c, qemu_command.c: add "up" (set to "true") to brAddTap() call.
This commit is contained in:
Laine Stump 2011-02-09 01:20:39 -05:00
parent e9bd5c0e24
commit 13ae7a02b3
4 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/qemu/qemu_command.c
View File

@ -252,6 +252,7 @@ qemuNetworkIfaceConnect(virConnectPtr conn,
&net->ifname,
tapmac,
vnet_hdr,
true,
&tapfd))) {
if (err == ENOTSUP) {
/* In this particular case, give a better diagnostic. */

1
src/uml/uml_conf.c
View File

@ -143,6 +143,7 @@ umlConnectTapDevice(virConnectPtr conn,
&net->ifname,
tapmac,
0,
true,
NULL))) {
if (err == ENOTSUP) {
/* In this particular case, give a better diagnostic. */

3
src/util/bridge.c
View File

@ -484,6 +484,7 @@ brAddTap(brControl *ctl,
char **ifname,
const unsigned char *macaddr,
int vnet_hdr,
bool up,
int *tapfd)
{
int fd;
@ -530,7 +531,7 @@ brAddTap(brControl *ctl,
goto error;
if ((errno = brAddInterface(ctl, bridge, ifr.ifr_name)))
goto error;
if ((errno = brSetInterfaceUp(ctl, ifr.ifr_name, 1)))
if (up && ((errno = brSetInterfaceUp(ctl, ifr.ifr_name, 1))))
goto error;
if (!tapfd &&
(errno = ioctl(fd, TUNSETPERSIST, 1)))

1
src/util/bridge.h
View File

@ -71,6 +71,7 @@ int brAddTap (brControl *ctl,
char **ifname,
const unsigned char *macaddr,
int vnet_hdr,
bool up,
int *tapfd);
int brDeleteTap (brControl *ctl,