External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-10-05 22:05:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

util: always replace g_fsync usage with our wrapper

Browse Source 
g_fsync was introduced in 2.63 which is newer than our minimum
glib version. A future commit will introduce compile time
checking of API versions to prevent accidental usage of APIs
from glib newer than our min declared.

To avoid triggering this warning, however, we need to ensure
that we always use our wrapper function via glibcompat.c,
which will disable the API version warnings.

Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
Daniel P. Berrangé 2020-01-06 11:42:17 +00:00
parent 97c7f3ead4
commit 14c136443c
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/util/glibcompat.c
View File

@ -55,6 +55,7 @@ vir_g_strdup_vprintf(const char *msg, va_list args)
}
/* Drop when min glib >= 2.63.0 */
gint
vir_g_fsync(gint fd)
{

5
src/util/glibcompat.h
View File

@ -32,6 +32,5 @@ gint vir_g_fsync(gint fd);
# define g_strdup_vprintf vir_g_strdup_vprintf
#endif
#if !GLIB_CHECK_VERSION(2, 63, 0)
# define g_fsync vir_g_fsync
#endif
#undef g_fsync
#define g_fsync vir_g_fsync