External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

virFileRemoveXAttr: Report error on failure

Browse Source 
It's better to have the function report errors, because none of
the callers does.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Cole Robinson <crobinso@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
Michal Privoznik 2019-03-22 15:41:06 +01:00
parent 9b130c33f9
commit 1596199067
1 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/util/virfile.c
View File

@ -4446,13 +4446,20 @@ virFileSetXAttr(const char *path,
* Remove xattr of @name on @path. * Remove xattr of @name on @path.
* *
* Returns: 0 on success, * Returns: 0 on success,
* -1 otherwise (with errno set). * -1 otherwise (with errno set AND error reported).
*/ */
int int
virFileRemoveXAttr(const char *path, virFileRemoveXAttr(const char *path,
const char *name) const char *name)
{ {
return removexattr(path, name); if (removexattr(path, name) < 0) {
virReportSystemError(errno,
_("Unable to remove XATTR %s on %s"),
name, path);
return -1;
}
return 0;
} }
#else /* !HAVE_LIBATTR */ #else /* !HAVE_LIBATTR */
@ -4479,10 +4486,13 @@ virFileSetXAttr(const char *path,
} }
int int
virFileRemoveXAttr(const char *path ATTRIBUTE_UNUSED, virFileRemoveXAttr(const char *path,
const char *name ATTRIBUTE_UNUSED) const char *name)
{ {
errno = ENOSYS; errno = ENOSYS;
virReportSystemError(errno,
_("Unable to remove XATTR %s on %s"),
name, path);
return -1; return -1;
} }