mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2025-04-01 20:05:19 +00:00
qemu: block: Use correct format name when formatting overlay of qcow2+luks
A logic bug in the code creating overlays on existing images resulted into wrongly using "luks" instead of "qcow2" for the backing format if the backing image is an luks-encrypted qcow2. The special format munging is needed only for raw luks images. In practice the impact is not as critical as to use encrypted images in the backing chain the user must fully describe the backing chain including backing images to provide encryption keys, which overrides the metadata recorded in the qcow2 header. Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
parent
ec5561c0bb
commit
15ab655835
@ -2264,7 +2264,8 @@ qemuBlockStorageSourceCreateAddBacking(virStorageSource *backing,
|
||||
return 0;
|
||||
|
||||
if (format) {
|
||||
if (backing->encryption &&
|
||||
if (backing->format == VIR_STORAGE_FILE_RAW &&
|
||||
backing->encryption &&
|
||||
backing->encryption->format == VIR_STORAGE_ENCRYPTION_FORMAT_LUKS)
|
||||
backingFormatStr = "luks";
|
||||
else
|
||||
|
Loading…
x
Reference in New Issue
Block a user