External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-10-05 22:05:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

virchrdev: Don't leak mutex if virChrdevAlloc() fails

Browse Source 
This is only a theoretical leak, but in virChrdevAlloc() we
initialize a mutex and if creating a hash table fails,
then virChrdevFree() is called which because of incorrect check
doesn't deinit the mutex.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
This commit is contained in:
Michal Privoznik 2020-01-08 09:18:30 +01:00
parent aab3779994
commit 15b821122e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/conf/virchrdev.c
View File

@ -311,7 +311,7 @@ static int virChrdevFreeClearCallbacks(void *payload,
*/ */
void virChrdevFree(virChrdevsPtr devs) void virChrdevFree(virChrdevsPtr devs)
{ {
if (!devs || !devs->hash) if (!devs)
return; return;
virMutexLock(&devs->lock); virMutexLock(&devs->lock);