External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-23 03:42:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemuValidateDomainDeviceDefVideo: Reject non-default video head count for devices not supporting it

Browse Source 
Only QXL and virtio-vga actually propagate the 'heads' attribute as
'max_outputs' to the commandline of qemu. Reject the setting when
non-default value is used for any other video type.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2036300
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Peter Krempa 2022-01-18 16:59:35 +01:00
parent 37c0a25ca0
commit 1652babf15
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/qemu/qemu_validate.c
View File

@ -2480,6 +2480,13 @@ qemuValidateDomainDeviceDefVideo(const virDomainVideoDef *video,
virDomainVideoTypeToString(video->type)); virDomainVideoTypeToString(video->type));
return -1; return -1;
} }
if (video->heads != 1) {
virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
_("video type '%s' doesn't support multiple 'heads'"),
virDomainVideoTypeToString(video->type));
return -1;
}
} }
if (video->accel && video->accel->accel2d == VIR_TRISTATE_SWITCH_ON) { if (video->accel && video->accel->accel2d == VIR_TRISTATE_SWITCH_ON) {