External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-07-17 07:07:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

conf: Ignore multiqueue with one queue.

Browse Source 
Multi != One.  And indeed, libvirt behaves the same way for queues='1'
as without such setting.  Let's make it clear in the XML.

Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
This commit is contained in:
Martin Kletzander 2015-06-04 11:23:28 +02:00
parent b0d2e31c5f
commit 181e02dfda
3 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/conf/domain_conf.c
View File

@ -8626,7 +8626,8 @@ virDomainNetDefParseXML(virDomainXMLOptionPtr xmlopt,
queues);
goto error;
}
def->driver.virtio.queues = q;
if (q > 1)
def->driver.virtio.queues = q;
}
if ((str = virXPathString("string(./driver/host/@csum)", ctxt))) {
if ((val = virTristateSwitchTypeFromString(str)) <= 0) {

6
tests/qemuxml2argvdata/qemuxml2argv-tap-vhost-incorrect.xml
View File

@ -28,6 +28,12 @@
<driver name='vhost' queues='5'/>
<backend tap='/dev/null' vhost='/dev/zero'/>
</interface>
<interface type='user'>
<mac address='52:54:00:e5:48:59'/>
<model type='virtio'/>
<driver name='vhost' queues='1'/>
<backend tap='/dev/null' vhost='/dev/zero'/>
</interface>
<serial type='pty'>
<target port='0'/>
</serial>

6
tests/qemuxml2xmloutdata/qemuxml2xmlout-tap-vhost-incorrect.xml
View File

@ -27,6 +27,12 @@
<model type='definitely-not-virtio'/>
<backend tap='/dev/null'/>
</interface>
<interface type='user'>
<mac address='52:54:00:e5:48:59'/>
<model type='virtio'/>
<driver name='vhost'/>
<backend tap='/dev/null' vhost='/dev/zero'/>
</interface>
<serial type='pty'>
<target port='0'/>
</serial>