External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-03 11:35:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

virtpm: Use corresponding type for argument for virTPM*CapsGet()

Browse Source 
In virtpm.h there are two functions exposed for querying swtpm
and swtpm_setup capabilities: virTPMSwtpmCapsGet() and
virTPMSwtpmSetupCapsGet(), respectively. The capabilities we are
interested in are defined in two separate enums
(virTPMSwtpmFeature and virTPMSwtpmSetupFeature), but these
functions accept capability as an unsigned int rather than their
respective enum. While this makes sense for
virTPMBinaryGetCaps(), which is a module internal helper that
both exposed functions call, there's no need for the functions
themselves to accept unsigned int.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
This commit is contained in:
Michal Privoznik 2022-07-20 09:11:31 +02:00
parent ebf84b2b36
commit 18d70df6fc
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/util/virtpm.c
View File

@ -345,13 +345,13 @@ virTPMBinaryGetCaps(virTPMBinary binary,
}
bool
virTPMSwtpmCapsGet(unsigned int cap)
virTPMSwtpmCapsGet(virTPMSwtpmFeature cap)
{
return virTPMBinaryGetCaps(VIR_TPM_BINARY_SWTPM, cap);
}
bool
virTPMSwtpmSetupCapsGet(unsigned int cap)
virTPMSwtpmSetupCapsGet(virTPMSwtpmSetupFeature cap)
{
return virTPMBinaryGetCaps(VIR_TPM_BINARY_SWTPM_SETUP, cap);
}

6
src/util/virtpm.h
View File

@ -28,9 +28,6 @@ char *virTPMGetSwtpmIoctl(void);
bool virTPMHasSwtpm(void);
bool virTPMSwtpmCapsGet(unsigned int cap);
bool virTPMSwtpmSetupCapsGet(unsigned int cap);
typedef enum {
VIR_TPM_SWTPM_FEATURE_CMDARG_PWD_FD,
@ -50,3 +47,6 @@ typedef enum {
VIR_ENUM_DECL(virTPMSwtpmFeature);
VIR_ENUM_DECL(virTPMSwtpmSetupFeature);
bool virTPMSwtpmCapsGet(virTPMSwtpmFeature cap);
bool virTPMSwtpmSetupCapsGet(virTPMSwtpmSetupFeature cap);