External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

virNetworkDHCPLeaseTimeDefParseXML: Output error when 'expiry' can't be parsed

Browse Source 
virStrToLong_ul doesn't report it's own error.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1918674
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Laine Stump <laine@redhat.com>
This commit is contained in:
Peter Krempa 2021-01-21 17:35:12 +01:00
parent d51ad0008d
commit 196ebfc240
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/conf/network_conf.c
View File

@ -418,8 +418,11 @@ virNetworkDHCPLeaseTimeDefParseXML(virNetworkDHCPLeaseTimeDefPtr *lease,
if (!(expirystr = virXMLPropString(node, "expiry"))) if (!(expirystr = virXMLPropString(node, "expiry")))
return 0; return 0;
if (virStrToLong_ul(expirystr, NULL, 10, &expiry) < 0) if (virStrToLong_ul(expirystr, NULL, 10, &expiry) < 0) {
virReportError(VIR_ERR_XML_ERROR,
_("failed to parse expiry value '%s'"), expirystr);
return -1; return -1;
}
if ((unitstr = virXMLPropString(node, "unit"))) { if ((unitstr = virXMLPropString(node, "unit"))) {
if ((unit = virNetworkDHCPLeaseTimeUnitTypeFromString(unitstr)) < 0) { if ((unit = virNetworkDHCPLeaseTimeUnitTypeFromString(unitstr)) < 0) {