From 19c633c6785e7f1d9c241a82269f6ec793d654a1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A1n=20Tomko?= Date: Wed, 3 Jun 2015 17:19:06 +0200 Subject: [PATCH] Do not access the domain definition in qemuMonitorFindBalloonObjectPath The monitor code does not hold the virDomainObjPtr lock and should not access the defitinion. --- src/qemu/qemu_monitor.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c index 9add05c9da..6947b08942 100644 --- a/src/qemu/qemu_monitor.c +++ b/src/qemu/qemu_monitor.c @@ -1091,7 +1091,6 @@ qemuMonitorFindBalloonObjectPath(qemuMonitorPtr mon) int ret = -1; char *path = NULL; qemuMonitorJSONListPathPtr *bprops = NULL; - virDomainObjPtr vm = mon->vm; if (mon->balloonpath) { return 0; @@ -1101,15 +1100,6 @@ qemuMonitorFindBalloonObjectPath(qemuMonitorPtr mon) return -1; } - /* Not supported */ - if (!vm->def->memballoon || - vm->def->memballoon->model != VIR_DOMAIN_MEMBALLOON_MODEL_VIRTIO) { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Memory balloon model must be virtio to " - "get memballoon path")); - return -1; - } - if (qemuMonitorJSONFindLinkPath(mon, "virtio-balloon-pci", &path) < 0) return -1;