External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-23 14:15:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemu: gpu: Sanitize error values in qemuVhostUserGPUGetPid

Browse Source 
The caller doesn't care about the actual return value, so return -1
rather than errno.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Peter Krempa 2019-11-13 13:17:11 +01:00
parent e22d844ef7
commit 19cfd7e598
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/qemu/qemu_vhost_user_gpu.c
View File

@ -61,7 +61,7 @@ qemuVhostUserGPUCreatePidFilename(const char *stateDir,
* @alias: video device alias
* @pid: pointer to pid
*
* Return -errno upon error, or zero on successful reading of the pidfile.
* Return -1 upon error, or zero on successful reading of the pidfile.
* If the PID was not still alive, zero will be returned, and @pid will be
* set to -1;
*/
@ -74,11 +74,13 @@ qemuVhostUserGPUGetPid(const char *binPath,
{
g_autofree char *pidfile = NULL;
pidfile = qemuVhostUserGPUCreatePidFilename(stateDir, shortName, alias);
if (!pidfile)
return -ENOMEM;
if (!(pidfile = qemuVhostUserGPUCreatePidFilename(stateDir, shortName, alias)))
return -1;
return virPidFileReadPathIfAlive(pidfile, pid, binPath);
if (virPidFileReadPathIfAlive(pidfile, pid, binPath) < 0)
return -1;
return 0;
}