External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-07 04:07:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemu: Ignore non-boolean CPU model properties

Browse Source 
The query-cpu-model-expansion is currently implemented for s390(x) only
and all CPU properties it returns are booleans. However, x86
implementation will report more types of properties. Without making the
code more tolerant older libvirt would fail to probe newer QEMU
versions.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
This commit is contained in:
Jiri Denemark 2017-01-11 14:35:52 +01:00
parent ec23791517
commit 19e06cfa25
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/qemu/qemu_monitor_json.c
View File

@ -4982,15 +4982,12 @@ qemuMonitorJSONParseCPUModelProperty(const char *key,
size_t n = machine_model->nprops;
bool supported;
if (virJSONValueGetBoolean(value, &supported) < 0)
return 0;
if (VIR_STRDUP(machine_model->props[n].name, key) < 0)
return -1;
if (virJSONValueGetBoolean(value, &supported) < 0) {
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
_("query-cpu-model-expansion reply data is missing a"
" feature support value"));
return -1;
}
machine_model->props[n].supported = supported;
machine_model->nprops++;