External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

virnetserver: Check for virNetServerClientInitKeepAlive() retval

Browse Source 
Since it's introduction in v0.9.7-147-gf4324e3292 the
virNetServerClientInitKeepAlive() function returned nothing than
a negative one. Fortunately, this did not pose any problem
because we ignored the retval happily. Well, it's time to check
for the retval because the function might fail regularly.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
Michal Privoznik 2020-05-05 11:29:13 +02:00
parent d901fd6092
commit 1baead31fa
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/rpc/virnetserver.c
View File

@ -306,8 +306,9 @@ int virNetServerAddClient(virNetServerPtr srv,
virNetServerDispatchNewMessage, virNetServerDispatchNewMessage,
srv); srv);
virNetServerClientInitKeepAlive(client, srv->keepaliveInterval, if (virNetServerClientInitKeepAlive(client, srv->keepaliveInterval,
srv->keepaliveCount); srv->keepaliveCount) < 0)
goto error;
virObjectUnlock(srv); virObjectUnlock(srv);
return 0; return 0;

2
src/rpc/virnetserverclient.c
View File

@ -1599,7 +1599,7 @@ virNetServerClientInitKeepAlive(virNetServerClientPtr client,
virObjectRef(client); virObjectRef(client);
client->keepalive = ka; client->keepalive = ka;
ret = 0;
cleanup: cleanup:
virObjectUnlock(client); virObjectUnlock(client);