External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-29 00:55:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

S390: Buffer too small for large CPU numbers.

Browse Source 
The output buffer for virFileReadAll was too small for systems with
more than 30 CPUs which leads to a log entry and incorrect behavior.
The new size will be sufficient for the current
architectural limits.

Signed-off-by: Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com>
(cherry picked from commit 4bdc8606e6)
This commit is contained in:
Viktor Mihajlovski 2012-10-05 15:59:08 +02:00 committed by Cole Robinson
parent 6730e6352f
commit 1bc28c283b
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/util/sysinfo.c
View File

@ -361,7 +361,7 @@ virSysinfoRead(void) {
goto no_memory; goto no_memory;
/* Gather info from /proc/cpuinfo */ /* Gather info from /proc/cpuinfo */
if (virFileReadAll(CPUINFO, 2048, &outbuf) < 0) { if (virFileReadAll(CPUINFO, 8192, &outbuf) < 0) {
virReportError(VIR_ERR_INTERNAL_ERROR, virReportError(VIR_ERR_INTERNAL_ERROR,
_("Failed to open %s"), CPUINFO); _("Failed to open %s"), CPUINFO);
return NULL; return NULL;
@ -376,7 +376,7 @@ virSysinfoRead(void) {
VIR_FREE(outbuf); VIR_FREE(outbuf);
/* Gather info from /proc/sysinfo */ /* Gather info from /proc/sysinfo */
if (virFileReadAll(SYSINFO, 4096, &outbuf) < 0) { if (virFileReadAll(SYSINFO, 8192, &outbuf) < 0) {
virReportError(VIR_ERR_INTERNAL_ERROR, virReportError(VIR_ERR_INTERNAL_ERROR,
_("Failed to open %s"), SYSINFO); _("Failed to open %s"), SYSINFO);
return NULL; return NULL;