mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-12-23 06:05:27 +00:00
Don't update vol details after build
This patch removes the call to vol update after the volume build completes. The update call is currently meaningless anyway because the vol build is passed a copy of the definition, so the update result is thrown away. More importantly, if the user specified a selinux label for the volume, the update call results in a double free of the label * src/storage/storage_backend_fs.c: remove the update call
This commit is contained in:
parent
8838ee39ab
commit
1c06eb18c3
@ -822,14 +822,6 @@ _virStorageBackendFileSystemVolBuild(virConnectPtr conn,
|
||||
return -1;
|
||||
}
|
||||
|
||||
/* Refresh allocation / permissions info, but not capacity */
|
||||
if (virStorageBackendUpdateVolTargetInfoFD(conn, &vol->target, fd,
|
||||
&vol->allocation,
|
||||
NULL) < 0) {
|
||||
close(fd);
|
||||
return -1;
|
||||
}
|
||||
|
||||
if (close(fd) < 0) {
|
||||
virReportSystemError(conn, errno,
|
||||
_("cannot close file '%s'"),
|
||||
|
Loading…
Reference in New Issue
Block a user