External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

remote: Drop useless cleanup in remoteDispatchNodeGet{CPU,Memory}Stats

Browse Source 
The function cannot fail once it starts populating
ret->params.params_val[i].field.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Jiri Denemark 2023-01-25 15:25:06 +01:00
parent d0f339170f
commit 1cf7e6ec05
1 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/remote/remote_daemon_dispatch.c
View File

@ -3310,11 +3310,6 @@ remoteDispatchNodeGetCPUStats(virNetServer *server G_GNUC_UNUSED,
cleanup: cleanup:
if (rv < 0) { if (rv < 0) {
virNetMessageSaveError(rerr); virNetMessageSaveError(rerr);
if (ret->params.params_val) {
for (i = 0; i < nparams; i++)
VIR_FREE(ret->params.params_val[i].field);
VIR_FREE(ret->params.params_val);
}
} }
VIR_FREE(params); VIR_FREE(params);
return rv; return rv;
@ -3377,11 +3372,6 @@ remoteDispatchNodeGetMemoryStats(virNetServer *server G_GNUC_UNUSED,
cleanup: cleanup:
if (rv < 0) { if (rv < 0) {
virNetMessageSaveError(rerr); virNetMessageSaveError(rerr);
if (ret->params.params_val) {
for (i = 0; i < nparams; i++)
VIR_FREE(ret->params.params_val[i].field);
VIR_FREE(ret->params.params_val);
}
} }
VIR_FREE(params); VIR_FREE(params);
return rv; return rv;