External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-12 15:52:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemuBuildHostNetStr: Explicitly enumerate net types

Browse Source 
We tend to prevent using 'default' in switches. And it is for a
good reason - control may end up in paths we wouldn't want for
new values. In this specific case, if qemuBuildHostNetStr is
called over VIR_DOMAIN_NET_TYPE_VHOSTUSER it would produce
meaningless output. Fortunately, there no such call yet.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Michal Privoznik 2016-08-16 08:48:04 +02:00
parent c266b60440
commit 1dcbef8a0f
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/qemu/qemu_command.c
View File

@ -3723,9 +3723,21 @@ qemuBuildHostNetStr(virDomainNetDefPtr net,
break; break;
case VIR_DOMAIN_NET_TYPE_USER: case VIR_DOMAIN_NET_TYPE_USER:
default: case VIR_DOMAIN_NET_TYPE_INTERNAL:
virBufferAddLit(&buf, "user"); virBufferAddLit(&buf, "user");
break; break;
case VIR_DOMAIN_NET_TYPE_HOSTDEV:
/* Should have been handled earlier via PCI/USB hotplug code. */
virObjectUnref(cfg);
return NULL;
case VIR_DOMAIN_NET_TYPE_VHOSTUSER:
/* Unsupported yet. */
break;
case VIR_DOMAIN_NET_TYPE_LAST:
break;
} }
if (vlan >= 0) { if (vlan >= 0) {