From 1edfce9b180f0d4ec23ecd26a173eb1e0351ab3c Mon Sep 17 00:00:00 2001 From: John Ferlan Date: Fri, 4 Dec 2015 10:40:06 -0500 Subject: [PATCH] storage: Set ret = -1 on failures in virStorageBackendUpdateVolTargetInfo While processing the volume for lseek, virFileReadHeaderFD, and virStorageFileGetMetadataFromBuf - failure would cause an error, but ret would not be set. That would result in an error message being sent, but successful status being returned. --- src/storage/storage_backend.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/storage/storage_backend.c b/src/storage/storage_backend.c index 1ee83aa308..8eb5b04635 100644 --- a/src/storage/storage_backend.c +++ b/src/storage/storage_backend.c @@ -1625,16 +1625,19 @@ virStorageBackendUpdateVolTargetInfo(virStorageSourcePtr target, if (lseek(fd, 0, SEEK_SET) == (off_t)-1) { virReportSystemError(errno, _("cannot seek to start of '%s'"), target->path); + ret = -1; goto cleanup; } if ((len = virFileReadHeaderFD(fd, len, &buf)) < 0) { virReportSystemError(errno, _("cannot read header '%s'"), target->path); + ret = -1; goto cleanup; } if (!(meta = virStorageFileGetMetadataFromBuf(target->path, buf, len, target->format, NULL))) { + ret = -1; goto cleanup; }