External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-20 07:59:00 +00:00
Code

storage: Cleanup virStorageFileBackendGlusterReadlinkCallback

Browse Source 
Rather than having two exit paths, let's use a @retval value
and VIR_STEAL_PTR in order to unite the exit path through the
error label.

Signed-off-by: John Ferlan <jferlan@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
John Ferlan 2019-02-12 06:23:01 -05:00
parent 9916f2a3c8
commit 1ee7294bed
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/storage/storage_file_gluster.c
View File

@ -262,6 +262,7 @@ virStorageFileBackendGlusterReadlinkCallback(const char *path,
size_t bufsiz = 0;
ssize_t ret;
struct stat st;
int retval = -1;
*linkpath = NULL;
@ -291,13 +292,13 @@ virStorageFileBackendGlusterReadlinkCallback(const char *path,
buf[ret] = '\0';
*linkpath = buf;
VIR_STEAL_PTR(*linkpath, buf);
return 0;
retval = 0;
error:
VIR_FREE(buf);
return -1;
return retval;
}