From 1f5863ec4627fd2b7c7727902b9a8c4d5194e232 Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Thu, 6 Oct 2022 11:12:51 +0200 Subject: [PATCH] conf: domain: Remove pointless XML node name validation in virSysinfoBIOSParseXML MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The only caller passes 'node' argument originating from an XPath lookup for the 'bios' element, so there's no point in checking it once more. Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko --- src/conf/domain_conf.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index f8091b9fb5..d24c0a9d2b 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -12084,12 +12084,6 @@ virSysinfoBIOSParseXML(xmlNodePtr node, ctxt->node = node; - if (!virXMLNodeNameEqual(node, "bios")) { - virReportError(VIR_ERR_XML_ERROR, "%s", - _("XML does not contain expected 'bios' element")); - return -1; - } - def->vendor = virXPathString("string(entry[@name='vendor'])", ctxt); def->version = virXPathString("string(entry[@name='version'])", ctxt); def->date = virXPathString("string(entry[@name='date'])", ctxt);