External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-24 06:35:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

udev_device_get_devpath might return NULL

Browse Source 
Fix crash on strdup in that case.
This commit is contained in:
Guido Günther 2009-12-07 19:00:11 +01:00
parent a4e09c1ed8
commit 1f60411686
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/node_device/node_device_udev.c
View File

@ -947,8 +947,14 @@ static int udevProcessStorage(struct udev_device *device,
{ {
union _virNodeDevCapData *data = &def->caps->data; union _virNodeDevCapData *data = &def->caps->data;
int ret = -1; int ret = -1;
const char* devnode;
data->storage.block = strdup(udev_device_get_devnode(device)); devnode = udev_device_get_devnode(device);
if(!devnode) {
VIR_DEBUG("No devnode for '%s'\n", udev_device_get_devpath(device));
goto out;
}
data->storage.block = strdup(devnode);
if (udevGetStringProperty(device, if (udevGetStringProperty(device,
"DEVNAME", "DEVNAME",
&data->storage.block) == PROPERTY_ERROR) { &data->storage.block) == PROPERTY_ERROR) {